Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: migrate test-infra to testify for executor/cte_test.go [DO NOT MERGE, JUST A DEMO] #27377

Closed
wants to merge 2 commits into from
Closed

executor: migrate test-infra to testify for executor/cte_test.go [DO NOT MERGE, JUST A DEMO] #27377

wants to merge 2 commits into from

Conversation

tisonkun
Copy link
Contributor

Signed-off-by: tison wander4096@gmail.com

What problem does this PR solve?

Issue Number: close #27097

Release note

None

@tisonkun
executor: migrate test-infra to testify for executor/cte_test.go
ab29ad5 
Signed-off-by: tison <wander4096@gmail.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 19, 2021
@tisonkun tisonkun mentioned this pull request Aug 19, 2021
Merged
@github-actions github-actions bot added the sig/execution SIG execution label Aug 19, 2021
@tisonkun
gofmt
91dd69f 
Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 19, 2021
@tisonkun tisonkun changed the title executor: migrate test-infra to testify for executor/cte_test.go executor: migrate test-infra to testify for executor/cte_test.go [DO NOT MERGE, JUST A DEMO] Aug 19, 2021
@tisonkun tisonkun closed this Aug 19, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 20, 2021
Merged
@tisonkun tisonkun deleted the issue-27097 branch March 4, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. sig/execution SIG execution size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate test-infra to testify for executor/cte_test.go
2 participants
@tisonkun @ti-chi-bot